Re: [HACKERS] Should buffer of initialization fork have aBM_PERMANENT flag - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Should buffer of initialization fork have aBM_PERMANENT flag
Date
Msg-id CAB7nPqSY7YNLqccXg7E2u-wkCVQEGx8Ln5hZatt9kaumsCcPBw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Should buffer of initialization fork have aBM_PERMANENT flag  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Mar 15, 2017 at 1:13 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, Mar 13, 2017 at 8:51 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>>> I agree with that, but I propose the attached version instead.  It
>>> seems cleaner to have the entire test for setting BM_PERMANENT in one
>>> place rather than splitting it up as you did.
>>
>> Fine for me. You may want to update the comment of BM_PERMANENT in
>> buf_internals.h as Artur has mentioned upthread. For example by just
>> adding "and init forks".
>
> OK, done, and back-patched all the way.

Thanks.
-- 
Michael



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [HACKERS] multivariate statistics (v25)
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] WIP: Faster Expression Processing v4