Re: Specifying the unit in storage parameter - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Specifying the unit in storage parameter
Date
Msg-id CAB7nPqRNvoqxbgu=B_RfJL-K0zYrAQPH++s_DKpdGwP+dErWQA@mail.gmail.com
Whole thread Raw
In response to Re: Specifying the unit in storage parameter  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Specifying the unit in storage parameter
List pgsql-hackers
On Wed, Aug 27, 2014 at 10:59 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
Not necessarily, because it's harmless.  It's there for purely
aesthetical reasons, so it's your choice whether to add it or not.
Having it there is slightly easier on somebody reading the code,
perhaps.
 
On my side, that's up to you Fujii-san. The patch does what it states, I only think that this extra 0 should be added either everywhere or nowhere. Not mandatory either: drop test_param_unit in the regression tests after running the test queries.
Regards,
--
Michael

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Next
From: Michael Paquier
Date:
Subject: Re: [TODO] Track number of files ready to be archived in pg_stat_archiver