Re: [HACKERS] Proposal for CSN based snapshots - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Proposal for CSN based snapshots
Date
Msg-id CAB7nPqQ18VO=ueMaompNVNiupw9d3G4aF+34Ds4dxhn5zDb9XA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Proposal for CSN based snapshots  (Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>)
Responses Re: [HACKERS] Proposal for CSN based snapshots
List pgsql-hackers
On Wed, Jun 21, 2017 at 1:48 PM, Alexander Kuzmenkov
<a.kuzmenkov@postgrespro.ru> wrote:
> Glad to see you working on this! I've been studying this topic too. Attached
> you can find a recently rebased version of Heikki's v4 patch.
> I also fixed a bug that appeared on report-receipts isolation test:
> XidIsConcurrent should report that a transaction is concurrent to ours when
> its csn equals our snapshotcsn.

I am finally looking at rebasing things properly now, and getting more
familiar in order to come up with a patch for the upcoming coming fest
(I can see some diff simplifications as well to impact less existing
applications), and this v5 is very suspicious. You are adding code
that should actually be removed. One such block can be found at the
beginning of the patch:   <indexterm>
+    <primary>txid_snapshot_xip</primary>
+   </indexterm>
+
+   <indexterm>
That's not actually a problem as I am reusing an older v4 from Heikki
now for the future, but I wanted to let you know about that first.
-- 
Michael



pgsql-hackers by date:

Previous
From: Sokolov Yura
Date:
Subject: [HACKERS] Increase Vacuum ring buffer.
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] bug in locking an update tuple chain