Re: Issue with query_is_distinct_for() and grouping sets - Mailing list pgsql-hackers

From David Rowley
Subject Re: Issue with query_is_distinct_for() and grouping sets
Date
Msg-id CAApHDvrD-=LgAzpSXtfHiPE22Cj04hM_otN2WwyXcXCtidk7eg@mail.gmail.com
Whole thread Raw
In response to Re: Issue with query_is_distinct_for() and grouping sets  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Issue with query_is_distinct_for() and grouping sets
List pgsql-hackers
On Thu, 23 Oct 2025 at 16:43, Richard Guo <guofenglinux@gmail.com> wrote:
> How about using the following wording in the commit message?
>
> "
> The previous logic in query_is_distinct_for() was incomplete because
> the check was insufficiently thorough and could return false when it
> should have returned true.
> "

"it could" might be more accurate. The function is under no obligation
to return true for every possible case.

David



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls
Next
From: Laurenz Albe
Date:
Subject: Re: doc: create table improvements