Re: Something seems weird inside tts_virtual_copyslot() - Mailing list pgsql-hackers

From David Rowley
Subject Re: Something seems weird inside tts_virtual_copyslot()
Date
Msg-id CAApHDvqyzSpF=XfVzPZhQKg3hxxS4UKE5JjzRuP6dqkHayQ=+Q@mail.gmail.com
Whole thread Raw
In response to Re: Something seems weird inside tts_virtual_copyslot()  (Andres Freund <andres@anarazel.de>)
Responses Re: Something seems weird inside tts_virtual_copyslot()
List pgsql-hackers
On Fri, 1 Dec 2023 at 13:14, Andres Freund <andres@anarazel.de> wrote:
> So I think adding an assert to ExecCopySlot(), perhaps with a comment saying
> that the restriction could be lifted with a bit of work, would be fine.

Thanks for looking at this again.

How about the attached?  I wrote the comment you mentioned and also
removed the Assert from tts_virtual_copyslot().

I also noted in the copyslot callback declaration that implementers
can assume the number of attributes in the source and destination
slots match.

David

Attachment

pgsql-hackers by date:

Previous
From: Tommy Pavlicek
Date:
Subject: Re: [PATCH] ltree hash functions
Next
From: Andres Freund
Date:
Subject: Re: Refactoring backend fork+exec code