Re: Something seems weird inside tts_virtual_copyslot() - Mailing list pgsql-hackers

From David Rowley
Subject Re: Something seems weird inside tts_virtual_copyslot()
Date
Msg-id CAApHDvqpgiu3yODWNpSE47pwq4g1HN5H1ObyDBHJuwAkVynG1w@mail.gmail.com
Whole thread Raw
In response to Re: Something seems weird inside tts_virtual_copyslot()  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Fri, 1 Dec 2023 at 14:30, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Fri, 1 Dec 2023 at 13:14, Andres Freund <andres@anarazel.de> wrote:
> > So I think adding an assert to ExecCopySlot(), perhaps with a comment saying
> > that the restriction could be lifted with a bit of work, would be fine.
>
> How about the attached?  I wrote the comment you mentioned and also
> removed the Assert from tts_virtual_copyslot().

I looked over this again and didn't see any issues, so pushed the patch.

Thanks for helping with this.

David



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: remaining sql/json patches
Next
From: Junwang Zhao
Date:
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations