Re: Executor code - found an instance of a WHILE that should just be an IF - Mailing list pgsql-hackers

From David Rowley
Subject Re: Executor code - found an instance of a WHILE that should just be an IF
Date
Msg-id CAApHDvqkeM39iNzVPBvN54jNQ3XR40G_sT+bcudeyODZwsfBmA@mail.gmail.com
Whole thread Raw
In response to Re: Executor code - found an instance of a WHILE that should just be an IF  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Executor code - found an instance of a WHILE that should just be an IF
List pgsql-hackers
On Mon, 10 May 2021 at 23:49, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Mon, 10 May 2021 at 21:16, Greg Nancarrow <gregn4422@gmail.com> wrote:
> > During debugging I noticed some code in ExecResult() where a WHILE
> > loop is being used with an unconditional RETURN at the end of the
> > block (which is intentional, looking at the history of changes), but
> > now there's no actual use of the loop in any way. The code should
> > probably be changed to just use IF for clarity.
> > I've attached a patch.
>
> Looks like leftovers from ea15e1867.
>
> I don't think this will affect any code generation but you are right,
> it should be an "if".

Since there's no bug fix here, I thought that there's not much point
in backpatching this.

Does anyone object to making this small change in master?

David



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Inherited UPDATE/DELETE vs async execution
Next
From: torikoshia
Date:
Subject: Re: RFC: Logging plan of the running query