Request a Demo
Home   >   mailing lists

Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options - Mailing list pgsql-hackers

From David Rowley
Subject Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date
Msg-id CAApHDvqFyY8gCFg7fN9v8R4b6QLshDsYV9y0nLvLjD5Nd4A7LQ@mail.gmail.com
Whole thread Raw
In response to Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options  (Henson Choi <assam258@gmail.com>)
Responses Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
List pgsql-hackers
Tree view 
On Mon, 29 Dec 2025 at 01:18, Henson Choi <assam258@gmail.com> wrote:
> - publicationcmds.c: real bug, affects event triggers
> - pgoutput.c: harmless, just API cleanup
>
> The bug in publicationcmds.c is minor in practice—it only affects users who
> have event triggers on publication DDL and use extensions that extract option
> values from pg_ddl_command. This is an uncommon case, but it is a real bug
> nonetheless.
>
> The patch should be applied.

Thank you for doing that analysis. I've followed that and agree with
your conclusion.

I've pushed the patch and backpatched to v14.

David

pgsql-hackers by date:

Previous
From: Jacob Jackson
Date:
Subject: Re: Proposal: Add a UNIQUE NOT ENFORCED constraint
Next
From: Michael Paquier
Date:
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE