Request a Demo
Home   >   mailing lists

Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options - Mailing list pgsql-hackers

From Henson Choi
Subject Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date
Msg-id CAAAe_zAJycKWaJA+FqS8aKfs_TO8364BEe+p-2xuvjwi0p75Jw@mail.gmail.com
Whole thread Raw
In response to Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
List pgsql-hackers
Tree view
Hi David,

Thank you for reviewing and committing the patch.
I appreciate the thorough backport to v14.

2026년 1월 6일 (화) PM 1:34, David Rowley <dgrowleyml@gmail.com>님이 작성:
On Mon, 29 Dec 2025 at 01:18, Henson Choi <assam258@gmail.com> wrote:
> - publicationcmds.c: real bug, affects event triggers
> - pgoutput.c: harmless, just API cleanup
>
> The bug in publicationcmds.c is minor in practice—it only affects users who
> have event triggers on publication DDL and use extensions that extract option
> values from pg_ddl_command. This is an uncommon case, but it is a real bug
> nonetheless.
>
> The patch should be applied.

Thank you for doing that analysis. I've followed that and agree with
your conclusion.

I've pushed the patch and backpatched to v14.

David

Thanks to Sunil for the original fix.

Best regards,
Henson

pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: RFC: adding pytest as a supported test framework
Next
From: Masahiko Sawada
Date:
Subject: Re: Refactor replication origin state reset helpers