Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Thu, 2 Oct 2025 at 23:00, Daniel Gustafsson <daniel@yesql.se> wrote:
> Doing post-commit review I didn't see any sharp edges, but found one more of
> these so will push this shortly:

Any chance you could also delete the "/* memory cleanup seems more
tricky than it's worth here */" line? That comment seemed relevant
when we were actually doing bms_free() in the functions. Now that
we're not, it's a bit out of place.

David



pgsql-hackers by date:

Previous
From: Greg Burd
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: Tatsuo Ishii
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options