> On 2 Oct 2025, at 14:11, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Thu, 2 Oct 2025 at 23:00, Daniel Gustafsson <daniel@yesql.se> wrote:
>> Doing post-commit review I didn't see any sharp edges, but found one more of
>> these so will push this shortly:
>
> Any chance you could also delete the "/* memory cleanup seems more
> tricky than it's worth here */" line? That comment seemed relevant
> when we were actually doing bms_free() in the functions. Now that
> we're not, it's a bit out of place.
Sure I can take care of that while in there.
Another nitpick would be to remove the test for NULL in test_bms_make_singleton
since that is a STRICT function, making the test for NULL superfluous code:
diff --git a/src/test/modules/test_bitmapset/test_bitmapset.c b/src/test/modules/test_bitmapset/test_bitmapset.c
index 0d6c2e7aa1b..acaa93d2f11 100644
--- a/src/test/modules/test_bitmapset/test_bitmapset.c
+++ b/src/test/modules/test_bitmapset/test_bitmapset.c
@@ -201,9 +201,6 @@ test_bms_make_singleton(PG_FUNCTION_ARGS)
Bitmapset *bms;
int32 member;
- if (PG_ARGISNULL(0))
- PG_RETURN_NULL(); /* invalid input */
-
member = PG_GETARG_INT32(0);
bms = bms_make_singleton(member);
I'll include all of these three tiny improvements in a commit later today.
--
Daniel Gustafsson
