Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options - Mailing list pgsql-hackers

From David Rowley
Subject Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date
Msg-id CAApHDvpSMq4CrQ-iwsfhsznKjtB0Xod6o3BngnyoCZPPkWgBSw@mail.gmail.com
Whole thread Raw
In response to Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
List pgsql-hackers
On Tue, 19 Aug 2025 at 01:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > I've purposefully left references to HASH_DEBUG in the "Original
> > comments" section near the top of dynahash.c. That comment also
> > references function names that no longer exist.
>
> Hm, there is actually no part of that comment para that is accurate
> anymore, so I cannot imagine a reason for leaving it alone.  People
> who want to do archaeology can consult the git history.  How about
> reducing the para to
>
>  * HASH_STATISTICS causes some usage statistics to be maintained,
>  * which can be logged by calling hash_stats().

Ok. I pushed it like that. Thanks for looking.

David



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Support getrandom() for pg_strong_random() source
Next
From: Masahiko Sawada
Date:
Subject: Re: Logical Replication of sequences