Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date
Msg-id 344325.1755524074@sss.pgh.pa.us
Whole thread Raw
In response to Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> I've purposefully left references to HASH_DEBUG in the "Original
> comments" section near the top of dynahash.c. That comment also
> references function names that no longer exist.

Hm, there is actually no part of that comment para that is accurate
anymore, so I cannot imagine a reason for leaving it alone.  People
who want to do archaeology can consult the git history.  How about
reducing the para to

 * HASH_STATISTICS causes some usage statistics to be maintained,
 * which can be logged by calling hash_stats().

LGTM otherwise.

            regards, tom lane



pgsql-hackers by date:

Previous
From: torikoshia
Date:
Subject: Re: Enhancing Memory Context Statistics Reporting
Next
From: Dominique Devienne
Date:
Subject: Re: Identifying function-lookup failures due to argument name mismatches