Re: Fix a reference error for window functions: In the function 'find_window_functions', the deduplication logic should be removed - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix a reference error for window functions: In the function 'find_window_functions', the deduplication logic should be removed
Date
Msg-id CAApHDvoqHpVdkkqNTZ-6LG673+yj02-pHJBAQevQgzk=PJcpxg@mail.gmail.com
Whole thread Raw
In response to Re: Fix a reference error for window functions: In the function 'find_window_functions', the deduplication logic should be removed  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Sun, 25 Jan 2026 at 23:14, David Rowley <dgrowleyml@gmail.com> wrote:
> I came up with the attached for that. I did write the list_uniquify()
> before I realised your fix is ok for master. That function might be
> misplaced just in the backbranches, and it might be better to just
> foreach and if (!list_member()) directly in optimize_window_clauses()
> to get rid of the duplicates. That's probably safer too.

I pushed the deduplication code removal to master and adjusted the
backpatch version to do the foreach -> if (!list_memeber()) as
mentioned above.

David



pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: Make copyObject work in C++
Next
From: "Jelte Fennema-Nio"
Date:
Subject: Re: Safer hash table initialization macro