Re: Incorrect usage of strtol, atoi for non-numeric junk inputs - Mailing list pgsql-hackers

From David Rowley
Subject Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
Date
Msg-id CAApHDvoBw_Kk0XGOJwshnwq68gMn7aZPKgPMzWv5s+ddzhpCog@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect usage of strtol, atoi for non-numeric junk inputs  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
List pgsql-hackers
On Thu, 22 Jul 2021 at 00:44, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jul 22, 2021 at 12:32:39AM +1200, David Rowley wrote:
> > I see both of these are limited to 64 on windows. Won't those fail on Windows?
>
> Yes, thanks, they would.  I would just cut the range numbers from the
> expected output here.  This does not matter in terms of coverage
> either.

Sounds good.

> x> I also wondered if it would be worth doing #define MAX_JOBS  somewhere
> > away from the option parsing code.  This part is pretty ugly:
>
> Agreed as well.  pg_dump and pg_restore have their own idea of
> parallelism in parallel.{c.h}.  What about putting MAX_JOBS in
> parallel.h then?

parallel.h looks ok to me.

David



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: when the startup process doesn't (logging startup delays)
Next
From: David Rowley
Date:
Subject: Re: ORDER BY pushdowns seem broken in postgres_fdw