Request a Demo
Home   >   mailing lists

Re: Don't synchronously wait for already-in-progress IO in read stream - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Don't synchronously wait for already-in-progress IO in read stream
Date
Msg-id CAAKRu_ZRf_t4=5y5nvq3BKoN8=8Dh77O0pi6s2kScXiAnA3eVQ@mail.gmail.com
Whole thread
In response to Re: Don't synchronously wait for already-in-progress IO in read stream  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: Don't synchronously wait for already-in-progress IO in read stream
List pgsql-hackers
Tree view 
On Mon, Mar 30, 2026 at 3:14 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> On Mon, Mar 30, 2026 at 3:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
> >
> > As copperhead showed [1], tests added in 020c02bd9 fail when postgres is
> > built without --enable-cassert. I've reproduced the failure locally with:
>
> Yes, it's because read_buffers() (in test_aio.c) uses
> operation->nblocks and that's only intialized for buffer hits in
> assert builds. The test code could just use the correctly initialized
> nblocks out parameter.

Fix was a little more invasive than that. Looks like we were using
operation in more places than I thought. See attached.

- Melanie
Attachment

pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: Fix race with LLVM and bison.
Next
From: David Rowley
Date:
Subject: Re: scale parallel_tuple_cost by tuple width