Re: Don't synchronously wait for already-in-progress IO in read stream - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Don't synchronously wait for already-in-progress IO in read stream
Date
Msg-id CAAKRu_Y2NeYkqf1wymzErYt9aWFXU5ebUSi2xWfsv3wY4HMEbw@mail.gmail.com
Whole thread Raw
In response to Re: Don't synchronously wait for already-in-progress IO in read stream  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: Don't synchronously wait for already-in-progress IO in read stream
List pgsql-hackers
On Mon, Mar 30, 2026 at 3:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
>
> As copperhead showed [1], tests added in 020c02bd9 fail when postgres is
> built without --enable-cassert. I've reproduced the failure locally with:

Yes, it's because read_buffers() (in test_aio.c) uses
operation->nblocks and that's only intialized for buffer hits in
assert builds. The test code could just use the correctly initialized
nblocks out parameter.

- Melanie



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUG] Excessive memory usage with update on STORED generated columns.
Next
From: Masahiko Sawada
Date:
Subject: Re: postgres_fdw: Use COPY to speed up batch inserts