Hi Tatsuo,
Catching up on today's notes -- all straightforward, so I'm folding them
into one reply.
> I'd prefer (3). Yes, I agree that 240 pattern variables is enough.
Then (3) it is -- and with Jian on the same choice, that closes it. I'll
go ahead with it. Since it's a narrowing it's only free pre-release, so
it goes in the v48 core rather than a later follow-up.
> static void
> nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext *ctx,
> int64 currentPos)
>
> This function does not have a forward declaration. Moreover, it is put
> in the "API exposed to nodeWindowAgg.c" section. [...] I suggest to add
> a forward declaration for it and move it before "API exposed to
> nodeWindowAgg.c" section.
Agreed -- that was just an oversight. I'll add the forward declaration
and move it out of the API-exposed section.
> nocfbot-0025-...:55:+ (errcode(ERRCODE_WINDOWING_ERROR),
> Maybe this is the only one worth to look into?
Right -- I'll update 0025 in the next posting.
Thanks,
Henson
