Re: Row pattern recognition - Mailing list pgsql-hackers

Hi Henson,

In execRPR.c:

static void
nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext *ctx,
                              int64 currentPos)

This function does not have a forward declaration. Moreover, it is put
in the "API exposed to nodeWindowAgg.c" section. If there's no
particular reason for this, I suggest to add a forward declaration for
it and move it before "API exposed to nodeWindowAgg.c" section.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp