Re: Row pattern recognition - Mailing list pgsql-hackers

From Henson Choi
Subject Re: Row pattern recognition
Date
Msg-id CAAAe_zA=BDm=e04aNFYe3Az0CzPipK+HHzu1KGHiLOg+r_z8XQ@mail.gmail.com
Whole thread Raw
In response to Re: Row pattern recognition  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Row pattern recognition
List pgsql-hackers
Hi Tatsuo,

> Therefore, I believe it only makes sense to add explicit initialization
> for nfaStatesActive and nfaContextsActive, since these are the only two
> that release_partition() also explicitly resets.

That makes sense.

Thank you for confirming.

> ## Proposal for consistency
>
>   /* Initialize NFA free lists for row pattern matching */
>   winstate->nfaContext = NULL;
>   winstate->nfaContextTail = NULL;
>   winstate->nfaContextFree = NULL;
>   winstate->nfaStateFree = NULL;
>   winstate->nfaLastProcessedRow = -1;
>   winstate->nfaStatesActive = 0;        // Add this
>   winstate->nfaContextsActive = 0;      // Add this
>
> Would you like me to include this change in the next patch?

Yes, please.


Done. Please see the attached patch.

Best regards,
Henson
 
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Change checkpoint‑record‑missing PANIC to FATAL
Next
From: "Euler Taveira"
Date:
Subject: Re: Pasword expiration warning