Re: Proposal: Add a callback data parameter to GetNamedDSMSegment - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Date
Msg-id CAA5RZ0s4p=D0D8vZ-5gmMfhr_q7GN6V2pgBhCewokO5hncQ=HA@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: Add a callback data parameter to GetNamedDSMSegment  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
> > I went back-forth on if it makes sense to provide the name as an
> > extra argument and decided it provides more flexibility. For example
> > I can use the same init callback and arguments for different segments.
>
> If the initialization callback function needed the name, it could be
> provided via the "void *" callback argument, right?  I'm not following why
> we need to provide it separately.

While it's true it can be passed as extra data, it is less error-prone
as we guarantee the real name of the segment is made available to
the callback. Also a caller to GetNamedDSMSegment does not need to
pass the name twice, as the name and as extra data. The most common
case I would think is using the segment name as the tranche name when
initializing a lwlock.

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: Proposal to allow setting cursor options on Portals