Postgres Pro
Downloads
Home   >   mailing lists

Re: Error code for checksum failure in origin.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Error code for checksum failure in origin.c
Date
Msg-id CAA4eK1Jt2hzNv=bMH8v8q34ed4pxWgPhtvX4f-CGncbV-Yj_OA@mail.gmail.com
Whole thread Raw
In response to Error code for checksum failure in origin.c  (Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>)
Responses Re: Error code for checksum failure in origin.c
List pgsql-hackers
Tree view 
On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito
<kasahara.tatsuhito@gmail.com> wrote:
>
> Hi.
>
> In the code in src/backend/replication/logical/origin.c,
> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given
> when a checksum check results in an error,
> but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.
>

+1. Your observation looks correct to me and the error code suggested
by you seems appropriate. We use ERRCODE_DATA_CORRUPTED in
ReadTwoPhaseFile() for similar error.

-- 
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: verify_heapam for sequences?
Next
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication