Re: Error code for checksum failure in origin.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Error code for checksum failure in origin.c
Date
Msg-id 03D55F32-C84F-44D6-9E64-F34408AF91AA@yesql.se
Whole thread Raw
In response to Re: Error code for checksum failure in origin.c  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Error code for checksum failure in origin.c
List pgsql-hackers
> On 26 Aug 2021, at 12:03, Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito
> <kasahara.tatsuhito@gmail.com> wrote:
>> 
>> Hi.
>> 
>> In the code in src/backend/replication/logical/origin.c,
>> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given
>> when a checksum check results in an error,
>> but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.
>> 
> 
> +1. Your observation looks correct to me and the error code suggested
> by you seems appropriate. We use ERRCODE_DATA_CORRUPTED in
> ReadTwoPhaseFile() for similar error.

Agreed, +1 for changing this.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication
Next
From: Ajin Cherian
Date:
Subject: Re: Failure of subscription tests with topminnow