Re: Distinguish publication exclusions in object addresses - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Distinguish publication exclusions in object addresses
Date
Msg-id CAA4eK1Jj61+hsEFYzApf-TrLbSKdeg6iHrO64j6jj2ROsYyP4A@mail.gmail.com
Whole thread
In response to Re: Distinguish publication exclusions in object addresses  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Wed, Sep 16, 2026 at 1:21 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Sep 16, 2026 at 5:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Sep 16, 2026 at 12:23 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Can you share an example of such a case?
> >
>
> My example was using 'publication relation' (not 'publication excluded
> relation') and I've already shared it.
>
> But that bug (?) already exists because this logic appears only aware
> of PUBLICATIONRELMAP rels and is not accounting for FOR ALL TABLES
> etc, so it reports an error like
> ERROR:  "t1" is not a published relation of publication "pub"
> even though table public.t1 does exist and really is a published
> relation of pub.
>

Right, but it is a different case as discussed. So, I would still
prefer to keep the same message to keep the code simple. Also, I would
like to push this patch after changing the Assert location as pointed
by Nisha unless you or others have any other comment.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Use C11 alignas instead of palloc/malloc for alignment
Next
From: Chao Li
Date:
Subject: Re: Distinguish publication exclusions in object addresses