> On Sep 16, 2026, at 15:37, vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 16 Sept 2026 at 12:16, Chao Li <li.evan.chao@gmail.com> wrote:
>>
>>
>>
>>> On Sep 16, 2026, at 13:50, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>>
>>> --
>>> With Regards,
>>> Amit Kapila.
>>> <v4-0001-Distinguish-publication-exclusions-in-object-addr.patch>
>>
>> V4 overall looks sold to me. Just a couple of small comments:
>>
>> 1
>> ```
>> -- No entry of either kind. testpub_default publishes nothing.
>> SELECT pg_get_object_address('publication excluded relation',
>> '{public, testpub_tbl1}', '{testpub_default}');
>> ERROR: publication relation "testpub_tbl1" in publication "testpub_default" does not exist
>> ```
>>
>> For this new test, the error message is a little surprising to me. Since the requested object type is "publication
excludedrelation", I would expect the error message to say something like:
>> ```
>> publication excluded relation "testpub_tbl1" in publication "testpub_default" does not exist
>> ```
>
> I think it would add some unnecessary code complexity in this case.
> Since the underlying issue is simply that the relation is not present
> in the publication, I think the existing generic error message is
> sufficient and should be understandable in the context of publication
> excluded relation.
>
I don’t think the fix would add much complexity, please see the attached diff I tried. This error message is shown to
users,so I think improving it is worthwhile.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
