Re: option -T in pg_basebackup doesn't work on windows - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: option -T in pg_basebackup doesn't work on windows
Date
Msg-id CAA4eK1J=NZYFYiXzeSFWFNjunZaXX-S279+xq-mYiAjg_b3YxQ@mail.gmail.com
Whole thread Raw
In response to Re: option -T in pg_basebackup doesn't work on windows  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: option -T in pg_basebackup doesn't work on windows
List pgsql-hackers
On Thu, Aug 21, 2014 at 3:44 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
> > >Wouldn't it make a lot more sense to create it correctly in the first place?
> >
> > Looking at the code, I think it is very well possible to create
> > it correctly in the first place without much extra work.  I will
> > send a patch if nobody sees any problem with this change.
>
> Attached patch implements the above suggested fix.
> I have removed the earlier code which was used to update the
> symlink path.

Today morning, I realised that there is one problem with the
patch I sent yesterday and the problem is that incase user
has not given -T option, it will not be able to create the symlink
for appropriate path.  Attached patch fix this issue.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: inherit support for foreign tables
Next
From:
Date:
Subject: Re: pg_receivexlog --status-interval add fsync feedback