Re: relation OID in ReorderBufferToastReplace error message - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: relation OID in ReorderBufferToastReplace error message
Date
Msg-id CAA4eK1+ir8Tu211=w4AFT53+GZzAhgVKG8beHrSiCEzo22NqgQ@mail.gmail.com
Whole thread Raw
In response to Re: relation OID in ReorderBufferToastReplace error message  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: relation OID in ReorderBufferToastReplace error message  (Jeremy Schneider <schnjere@amazon.com>)
List pgsql-hackers
On Fri, Sep 17, 2021 at 10:53 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> I don't think it is a bad idea to print additional information as you
> are suggesting but why only for this error? It could be useful to
> investigate any other error we get during decoding. I think normally
> we add such additional information via error_context. We have recently
> added/enhanced it for apply-workers, see commit [1].
>
> I think here we should just print the relation name in the error
> message you pointed out and then work on adding additional information
> via error context as a separate patch. What do you think?
>

Attached please find the patch which just modifies the current error
message as proposed by you. I am planning to commit it in a day or two
unless there are comments or any other suggestions.

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication
Next
From: Dilip Kumar
Date:
Subject: Re: row filtering for logical replication