Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabledcontrols needs to be separately identified - Mailing list pgadmin-hackers

From Nagesh Dhope
Subject Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabledcontrols needs to be separately identified
Date
Msg-id CAA3zdZoVf-A32=m6DYiizzeNLZRFYM0yAq-S9Pt4eYPh_SfU7g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabledcontrols needs to be separately identified  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabledcontrols needs to be separately identified  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Akshay,
Please find a patch to make controls under Active query details subnode read-only on the dashboard.


On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated patch to include dialogs (create/edit) for all the nodes.
Kindly review.

On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

As per discussion, we should visit all the nodes create/edit dialog and make the controls read-only wherever appropriate.

On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to allow input controls to be set as readonly instead of disabled.
I've also changed the code for the nodes to make sure properties tab have readonly fields wherever applicable. This will allow tab navigation in properties tab and also allow screen readers to read it.
Please note that, I've not visited each and every node create/edit dialog to identify what should be readonly or what should be disabled as it depends on business logic. The patch is mainly for the properties tab.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks,
Nagesh
Attachment

pgadmin-hackers by date:

Previous
From: Pradip Parkale
Date:
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Set Active query details subnode control as read-only