Request a Demo
Home   >   mailing lists

Re: Move FOR PORTION OF checks out of analysis - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: Move FOR PORTION OF checks out of analysis
Date
Msg-id CA+renyXPgU4VMsc+d9OddPR-NGYsSdntXdEZELAzpp6t7xiA9A@mail.gmail.com
Whole thread
In response to Re: Move FOR PORTION OF checks out of analysis  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Move FOR PORTION OF checks out of analysis
List pgsql-hackers
Tree view 
On Wed, Jun 24, 2026 at 2:54 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> I have checked the patch v9 0002 "Move FOR PORTION OF volatile check
> into planner".  Functionality-wise, this seems correct.
>
> Could you explain why you used EXPRKIND_TARGET?  Maybe there is a good
> reason, but otherwise it seems kind of arbitrary.

This expression is used in the target list to set the application-time
column. We intersect the old value with the FOR PORTION OF bounds.

> The new ereport call in planner.c has some funny parentheses: You have
> parentheses around errmsg, but not around errcode.  This is probably
> because of the way this was copy and pasted from its previous location.

Here are new patches with the parens cleaned up.

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com
Attachment

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: [PATCH] Fix null pointer dereference in PG19
Next
From: Zsolt Parragi
Date:
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade