Re: Inval reliability, especially for inplace updates - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: Inval reliability, especially for inplace updates
Date
Msg-id CA+renyVbRfcVcgASk_JhWL-o-WmkD64z1EUVtpYEUORuXaZ_Jw@mail.gmail.com
Whole thread Raw
In response to Re: Inval reliability, especially for inplace updates  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Thu, Dec 11, 2025 at 4:24 PM Noah Misch <noah@leadboat.com> wrote:
>
> On Thu, Dec 04, 2025 at 04:19:02PM -0800, Noah Misch wrote:
> > Thanks for the review.
>
> > The attached version doesn't need a comprehensive re-review, but I'd
> > particularly value hearing about any places where you find it's reducing
> > comprehensibility rather than enhancing.
>
> I'd like to get this into the back branches well in advance of the 2026-02
> releases, in case the buildfarm catches some defect at low probability.  If
> there are no objections in the next week, I'll proceed that way.

I'm happy with these new comments. The explanation in
heap_inplace_lock before calling CacheInvalidateHeapTupleInplace is a
lot better I think. And removing the last param means there is less to
think about.

Thanks!

--
Paul              ~{:-)
pj@illuminatedcomputing.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_plan_advice
Next
From: Tom Lane
Date:
Subject: Re: On non-Windows, hard depend on uselocale(3)