Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
Date
Msg-id CA+hUKGLyS-GK_rkENaVbFVTa4VJ+reJxWtt+q4gmgNUXhptfYA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
List pgsql-hackers
On Tue, Jul 29, 2025 at 8:52 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> On Thu, Jun 26, 2025 at 4:33 PM Jacob Champion
> <jacob.champion@enterprisedb.com> wrote:
> > My plan, if this code seems reasonable, is to backport 0001-0003, but
> > keep the larger 0004 on HEAD only until it has proven to be stable.
> > It's a big new suite and I want to make sure it's not flapping on some
> > buildfarm animal. Eventually I'll backport that too.
>
> Any thoughts on the approach? Too big/too scary/too BSD-specific?
>
> A small bit of self-review: a comment I wrote in the tests suggested
> that the choice of readable/writable events was up to the multiplexer
> implementation, but it *must* choose readable, due to the hardcoded
> use of PGRES_POLLING_READING throughout the current code. Updated in
> v2.

[FYI, I'm looking into this and planning to post a review in 1-2 days...]



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: set role issue
Next
From: Dean Rasheed
Date:
Subject: Re: Improving and extending int128.h to more of numeric.c