On Wed, Nov 9, 2022 at 1:54 PM Andres Freund <andres@anarazel.de> wrote:
> On 2022-11-09 11:42:36 +1300, Thomas Munro wrote:
> > On Sat, Sep 17, 2022 at 6:27 PM Simon Riggs
> > <simon.riggs@enterprisedb.com> wrote:
> > > I've cleaned up the comments and used a #define for the constant.
> > >
> > > IMHO this is ready for commit. I will add it to the next CF.
> >
> > FYI This had many successful cfbot runs but today it blew up on
> > Windows when the assertion TransactionIdPrecedesOrEquals(safeXid,
> > snap->xmin) failed:
> >
> >
https://api.cirrus-ci.com/v1/artifact/task/5311549010083840/crashlog/crashlog-postgres.exe_1c40_2022-11-08_00-20-28-110.txt
>
> I don't immediately see how that could be connected to this patch - afaict
> that crash wasn't during recovery, and the modified functions should only be
> active during hot standby.
Indeed, sorry for the noise.