Re: Relation bulk write facility - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Relation bulk write facility
Date
Msg-id CA+hUKGJ8oBeNA_FJj9FwdVsnHCoSyWtoqkwepws+zsoKVEitTA@mail.gmail.com
Whole thread Raw
In response to Re: Relation bulk write facility  (Noah Misch <noah@leadboat.com>)
Responses Re: Relation bulk write facility
List pgsql-hackers
On Sun, Feb 25, 2024 at 8:50 AM Noah Misch <noah@leadboat.com> wrote:
> On GNU/Linux x64, gcc correctly records alignment=2**12 for the associated
> section (.rodata for bulk_write.o zero_buffer, .bss for pg_prewarm.o
> blockbuffer).  If I'm reading this right, neither AIX gcc nor xlc is marking
> the section with sufficient alignment, in bulk_write.o or pg_prewarm.o:

Ah, that is a bit of a hazard that we should probably document.

I guess the ideas to fix this would be: use smgrzeroextend() instead
of this coding, and/or perhaps look at the coding of pg_pwrite_zeros()
(function-local static) for any other place that needs such a thing,
if it would be satisfied by function-local scope?



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Relation bulk write facility
Next
From: Thomas Munro
Date:
Subject: Re: Relation bulk write facility