Postgres Pro
Downloads
Home   >   mailing lists

Re: [patch] some PQExpBuffer are not destroyed in pg_dump - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [patch] some PQExpBuffer are not destroyed in pg_dump
Date
Msg-id CA+fd4k49nPyHh3RmzrwFFRjo0woabqL14gg30KkUS75w_+y5wg@mail.gmail.com
Whole thread Raw
In response to [patch] some PQExpBuffer are not destroyed in pg_dump  ("Zhang, Jie" <zhangjie2@cn.fujitsu.com>)
Responses Re: [patch] some PQExpBuffer are not destroyed in pg_dump  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Tue, 7 Apr 2020 at 11:42, Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
>
> Hi al
>
> In getDefaultACLs function, some PQExpBuffer are not destroy
>

Yes, it looks like an oversight. It's related to the commit
e2090d9d20d809 which is back-patched to 9.6.

The patch looks good to me.

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: WAL usage calculation patch
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - test whether a variable exists