Re: tableam: inconsistent parameter name - Mailing list pgsql-hackers

From Robert Haas
Subject Re: tableam: inconsistent parameter name
Date
Msg-id CA+TgmobaXbhgSkVrEYXH7SJm6pGg6hBK743YGQgdAD8VufYVig@mail.gmail.com
Whole thread Raw
In response to Re: tableam: inconsistent parameter name  (Andres Freund <andres@anarazel.de>)
Responses Re: tableam: inconsistent parameter name
List pgsql-hackers
On Fri, Jun 7, 2019 at 12:52 PM Andres Freund <andres@anarazel.de> wrote:
> On 2019-06-07 12:37:33 -0400, Robert Haas wrote:
> > TableAmRoutine's index_build_range_scan thinks that parameter #8 is
> > called end_blockno, but table_index_build_range_scan and
> > heapam_index_build_range_scan and BRIN's summarize_range all agree
> > that it's the number of blocks to be scanned.  I assume that this got
> > changed at some point while Andres was hacking on it and this one
> > place just never got updated.
>
> Not sure where it came from :/
>
> > Proposed patch attached.  Since this seems like a bug, albeit a
> > harmless one, I propose to commit this to v12.
>
> Yea, please do!

I found what appears to be another typo very nearby.  Attached please
find v2, fixing both issues.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: tableam: inconsistent parameter name
Next
From: Andres Freund
Date:
Subject: Re: tableam: inconsistent parameter name