Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly - Mailing list pgsql-hackers

From Robert Haas
Subject Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Date
Msg-id CA+Tgmob_WGK+vKzE6FmrMmuwuv4myntfRAkEbo+tsDt9xUwCLQ@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Feb 27, 2018 at 5:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I ran the postgres_fdw regression test with no sleep two times in a
>> CLOBBER_CACHE_ALWAYS-enabled build, and then the regression test with
>> the sleep (60 seconds) two times, but I couldn't reproduce that in both
>> cases.  I suspect the changes in the order of the RETURNING output there
>> was still caused by autovacuum kicking in partway through the run.  So
>> to make the regression test more stable against autovacuum, I'd propose
>> to modify the regression test to disable autovacuum for the remote table
>> (ie "S 1"."T 1") (and perform VACUUM ANALYZE to that table manually
>> instead) in hopes of getting that fixed.  Attached is a patch for that.
>>   I think changes added by the previous patch wouldn't make sense
>> anymore, so I removed those changes.
>
> Ping?  We're still seeing those failures on jaguarundi.

This is another patch that got past me.  Committed now.

I'd be lying if I said I was filled with confidence that this was
going to fix it, but I don't know what to do other than keep tinkering
with it until we find something that works.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Direct converting numeric types to bool
Next
From: "Alex Ignatov"
Date:
Subject: RE: Direct converting numeric types to bool