Re: 'converts internal representation to "..."' comment is confusing - Mailing list pgsql-hackers

From Robert Haas
Subject Re: 'converts internal representation to "..."' comment is confusing
Date
Msg-id CA+TgmobRyH03_gbSVuggQ2Yh5iemhLOawyiNssLOKu-tUmkD1w@mail.gmail.com
Whole thread Raw
In response to Re: 'converts internal representation to "..."' comment is confusing  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 'converts internal representation to "..."' comment is confusing
List pgsql-hackers
On Sun, May 14, 2023 at 9:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Steve Chavez <steve@supabase.io> writes:
> > I found "..." confusing in some comments, so this patch changes it to
> > "cstring". Which seems to be the intention after all.
>
> Those comments are Berkeley-era, making them probably a decade older
> than the "cstring" pseudotype (invented in b663f3443).  Perhaps what
> you suggest is an improvement, but I'm not sure that appealing to
> original intent can make the case.

FWIW, it does seem like an improvement to me.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: cutting down the TODO list thread
Next
From: Dave Cramer
Date:
Subject: Re: pgbench: option delaying queries till connections establishment?