Re: Review of pg_archivecleanup -x option patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Review of pg_archivecleanup -x option patch
Date
Msg-id CA+Tgmob4NdTWAWy=bX5woT2jAYnGA8AxbE1cRggJmitX1_cNbQ@mail.gmail.com
Whole thread Raw
In response to Re: Review of pg_archivecleanup -x option patch  (Greg Smith <greg@2ndQuadrant.com>)
Responses Re: Review of pg_archivecleanup -x option patch
List pgsql-hackers
On Sun, Feb 12, 2012 at 9:19 PM, Greg Smith <greg@2ndquadrant.com> wrote:
> The smaller step of automatically stripping the specified suffix from the
> input file name, when it matches the one we've told the program to expect,
> seems like a usability improvement unlikely to lead to bad things though.
>  I've certainly made the mistake you've shown when using the patched version
> of the program myself, just didn't think about catching and correcting it
> myself before.  We can rev this to add that feature and resubmit easily
> enough, will turn that around soon.

This change seems plenty small enough to slip in even at this late
date, but I guess we're lacking a new version of the patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Avoiding shutdown checkpoint at failover
Next
From: Peter Geoghegan
Date:
Subject: Re: pg_stat_statements and planning time