Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_walinspect: ReadNextXLogRecord's first_record argument - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_walinspect: ReadNextXLogRecord's first_record argument
Date
Msg-id CA+Tgmob3FC+ot6vpunEeAQiq51fFe6XPEHKi57=KBDYxL-WCEw@mail.gmail.com
Whole thread Raw
In response to Re: pg_walinspect: ReadNextXLogRecord's first_record argument  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: pg_walinspect: ReadNextXLogRecord's first_record argument
List pgsql-hackers
Tree view 
On Wed, Aug 17, 2022 at 12:41 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> Agreed.
>
> Here's a patch (for V15 as well) fixing this bug, please review.

Couldn't you simplify this further by removing the lsn argument from
GetWALRecordInfo and using record->ReadRecPtr instead? Then
InitXLogReaderState's second argument could be XLogRecPtr instead of
XLogRecPtr *.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Generalize ereport_startup_progress infrastructure
Next
From: Bharath Rupireddy
Date:
Subject: Re: pg_walinspect: ReadNextXLogRecord's first_record argument