Re: flags argument for dsm_create - Mailing list pgsql-hackers

From Robert Haas
Subject Re: flags argument for dsm_create
Date
Msg-id CA+TgmoaBpo+x8FNjcqVUaNvY8A_1YApn6B3tUuB6xTssecd-1A@mail.gmail.com
Whole thread Raw
In response to Re: flags argument for dsm_create  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Thu, Mar 19, 2015 at 12:21 PM, Stephen Frost <sfrost@snowman.net> wrote:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>> > I'm slightly confused.  Does that mean "just change it" or does that
>> > mean "add dsm_create_extended instead"?
>>
>> FWIW, I vote for "just change it".  We change C-level APIs all the time,
>> and this function has surely not got either the longevity nor the wide
>> usage that might argue for keeping its API sancrosanct.
>
> Agreed.

OK, committed that way after, uh, actually testing it and fixing the bugs.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: GSoC 2015: Extra Jsonb functionality
Next
From: Bruce Momjian
Date:
Subject: Re: Collation-aware comparisons in GIN opclasses