Re: New pgbench functions are misnamed - Mailing list pgsql-hackers

From Robert Haas
Subject Re: New pgbench functions are misnamed
Date
Msg-id CA+Tgmoa2fOWPdyeFahKbsi8e2hmHWpW=zM-eAF_x6qj-Q36CVA@mail.gmail.com
Whole thread Raw
In response to New pgbench functions are misnamed  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: New pgbench functions are misnamed  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, May 4, 2016 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I noticed that commit 7e137f846 added functions named max() and min()
> to pgbench's expression syntax.  Unfortunately, these functions have
> zilch to do with what max() and min() do in SQL.  They're actually more
> like the greatest() and least() server-side functions.
>
> While I can't imagine that we'd ever want to implement true aggregates
> in pgbench expressions, it still seems like this is a recipe for
> confusion.  Shouldn't we rename these to greatest() and least()?

Yeah, that's probably a good idea.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg9.6 segfault using simple query (related to use fk for join estimates)
Next
From: Robert Haas
Date:
Subject: Re: what to revert