Re: New pgbench functions are misnamed - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New pgbench functions are misnamed
Date
Msg-id 21773.1462470217@sss.pgh.pa.us
Whole thread Raw
In response to Re: New pgbench functions are misnamed  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, May 4, 2016 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I noticed that commit 7e137f846 added functions named max() and min()
>> to pgbench's expression syntax.  Unfortunately, these functions have
>> zilch to do with what max() and min() do in SQL.  They're actually more
>> like the greatest() and least() server-side functions.
>> 
>> While I can't imagine that we'd ever want to implement true aggregates
>> in pgbench expressions, it still seems like this is a recipe for
>> confusion.  Shouldn't we rename these to greatest() and least()?

> Yeah, that's probably a good idea.

The vote seems to be 2 to 1 in favor, so I'll go do this.
        regards, tom lane



pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Initial release notes created for 9.6
Next
From: Tom Lane
Date:
Subject: Re: Initial release notes created for 9.6