Re: possible dsm bug in dsm_attach() - Mailing list pgsql-hackers

From Robert Haas
Subject Re: possible dsm bug in dsm_attach()
Date
Msg-id CA+TgmoZniszcj5OMsY7e55qC_EoLvwoTOML4qei3zX28wKPnKQ@mail.gmail.com
Whole thread Raw
In response to Re: possible dsm bug in dsm_attach()  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: possible dsm bug in dsm_attach()  (Andres Freund <andres@2ndquadrant.com>)
Re: possible dsm bug in dsm_attach()  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, May 6, 2014 at 1:14 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2014-05-06 08:48:57 -0400, Robert Haas wrote:
>> On Tue, May 6, 2014 at 8:43 AM, Andres Freund <andres@2ndquadrant.com> wrote:
>> > The break because of refcnt == 1 doesn't generally seem to be a good
>> > idea. Why are we bailing if there's *any* segment that's in the process
>> > of being removed? I think the check should be there *after* the
>> > dsm_control->item[i].handle == seg->handle check?
>>
>> You are correct.  Good catch.
>
> Fix attached.

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Release schedule for PG 9.4beta1
Next
From: Andres Freund
Date:
Subject: Re: possible dsm bug in dsm_attach()