Postgres Pro
Downloads
Home   >   mailing lists

Re: possible dsm bug in dsm_attach() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: possible dsm bug in dsm_attach()
Date
Msg-id 20140506171418.GA2583@awork2.anarazel.de
Whole thread Raw
In response to Re: possible dsm bug in dsm_attach()  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: possible dsm bug in dsm_attach()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On 2014-05-06 08:48:57 -0400, Robert Haas wrote:
> On Tue, May 6, 2014 at 8:43 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> > The break because of refcnt == 1 doesn't generally seem to be a good
> > idea. Why are we bailing if there's *any* segment that's in the process
> > of being removed? I think the check should be there *after* the
> > dsm_control->item[i].handle == seg->handle check?
>
> You are correct.  Good catch.

Fix attached.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers
Next
From: Tom Lane
Date:
Subject: Release schedule for PG 9.4beta1