Re: patch to allow disable of WAL recycling - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch to allow disable of WAL recycling
Date
Msg-id CA+TgmoZhGi22Uw68Zrfj1PcDhLFY6p19nSWbS1mz7yhen67TWg@mail.gmail.com
Whole thread Raw
In response to Re: patch to allow disable of WAL recycling  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: patch to allow disable of WAL recycling
List pgsql-hackers
On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek <jerry.jelinek@joyent.com> wrote:
> The latest patch is rebased, builds clean, and passes some basic testing. Please let me know if there is anything
elseI could do on this.
 

I agree with Thomas Munro's earlier critique of the documentation.
The documentation of the new parameters makes an assumption,
completely unsupported in my view, about when those parameters should
be set, yet at the same time gives almost no information about what
they actually do.  I don't like that.

The patch needs a visit from pgindent, too.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Michael Banck
Date:
Subject: Re: Online verification of checksums