Re: [HACKERS] Compiler warning in costsize.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Compiler warning in costsize.c
Date
Msg-id CA+TgmoZ+8-Z8s1YteZ254ULQzJb_oMGBB4Rdt2UEB2XRq76cNQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Compiler warning in costsize.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Compiler warning in costsize.c  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Mon, Apr 10, 2017 at 2:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>> Why bother with the 'rte' variable at all if it's only used for the
>> Assert()ing the rtekind?
>
> That was proposed a few messages back.  I don't like it because it makes
> these functions look different from the other scan-cost-estimation
> functions, and we'd just have to undo the "optimization" if they ever
> grow a need to reference the rte for another purpose.

I think that's sort of silly, though.  It's a trivial difference,
neither likely to confuse anyone nor difficult to undo.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [HACKERS] recent deadlock regression test failures
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] valgrind errors around dsa.c