Re: [HACKERS] Compiler warning in costsize.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Compiler warning in costsize.c
Date
Msg-id 30487.1491847763@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Compiler warning in costsize.c  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: [HACKERS] Compiler warning in costsize.c
List pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> Why bother with the 'rte' variable at all if it's only used for the
> Assert()ing the rtekind?

That was proposed a few messages back.  I don't like it because it makes
these functions look different from the other scan-cost-estimation
functions, and we'd just have to undo the "optimization" if they ever
grow a need to reference the rte for another purpose.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Compiler warning in costsize.c
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] recent deadlock regression test failures