Re: cross-platform pg_basebackup - Mailing list pgsql-hackers

From Robert Haas
Subject Re: cross-platform pg_basebackup
Date
Msg-id CA+TgmoYqFAvs1hZOqgcRyi0Ecu7A+wQQ7yc=Sd8U2O4SwfHDHg@mail.gmail.com
Whole thread Raw
In response to Re: cross-platform pg_basebackup  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: cross-platform pg_basebackup  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Oct 20, 2022 at 12:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > However, I think we could relax the check a little bit, something
> > along the lines of !is_nonwindows_absolute_path(cell->old_dir) &&
> > !is_windows_absolute_path(dir). We can't actually know whether the
> > remote side is Windows or non-Windows, but if the string we're given
> > is plausibly an absolute path under either set of conventions, it's
> > probably fine to just search the list for it and see if it shows up.
>
> Seems reasonable.

Cool. Here's a patch.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: sirisha chamarthi
Date:
Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Next
From: Tom Lane
Date:
Subject: Re: cross-platform pg_basebackup