Re: patch for xidin - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch for xidin
Date
Msg-id CA+TgmoYJ5Ztj21bKU7SzeSdfn8u7RJGUYYEtfJigvQC5YfAZBw@mail.gmail.com
Whole thread Raw
In response to Re: patch for xidin  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Apr 17, 2015 at 10:27 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The patch will correct it. I have justly copy some code of 'OID'. Whether we need to extract the common code?
>
> This seems like an awful lot of code to solve a problem that will never
> occur in practice.

It does seem like an awful lot of code.  We should be able to come up
with something shorter.  But the bug report is legitimate.  It's not
too much to ask that data types sanity check their inputs.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Add transforms feature
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] libpq: Allow specifying multiple host names to try to connect to