Re: patch for xidin - Mailing list pgsql-hackers

From Tom Lane
Subject Re: patch for xidin
Date
Msg-id 5031.1429280841@sss.pgh.pa.us
Whole thread Raw
In response to patch for xidin  ("Zhang Zq" <zqzhangmail@163.com>)
Responses Re: patch for xidin
List pgsql-hackers
"Zhang Zq" <zqzhangmail@163.com> writes:
>    The implements of 'xidin' use only ¡®strtoul¡¯ to cast from string to xid. So in some cases, may cause confusion,
forexample,
 
> The sql 'select c1 from test where xmin='abc' can be executed.  and sometimes will make mistakes, I want to query
"selectc1 from test where xmin='0x10'" ,but write 'Ox10', '0' to 'O',The result is obviously wrong.
 

> The patch will correct it. I have justly copy some code of 'OID'. Whether we need to extract the common code?

This seems like an awful lot of code to solve a problem that will never
occur in practice.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Manipulating complex types as non-contiguous structures in-memory
Next
From: Andrew Dunstan
Date:
Subject: Buildfarm client version 4.15 released